Jonatan Männchen

Results 305 comments of Jonatan Männchen

@caioaao I’m open to extend the telemetry events with additional metadata like requests and responses. That should be rather simple to extend: https://github.com/erlef/oidcc/blob/2578d2bbd1d09882e122ae9c0141fa6ae6df3e62/src/oidcc_http_util.erl#L114 If we add additional metadata, we should...

@caioaao Ok, can you define what we would need to add to the events? Once we agree about that I'm very open to a PR implementing this. What for sure...

@caioaao What is meant with total size? If it's about the HTTP message itself, I don't think that you can get this information from httpc. Everything else seems to make...

@LostKobrakai This is on purpose. I would however welcome a specific and better error message. Relevant Spec: https://openid.net/specs/openid-connect-core-1_0.html#IDTokenValidation > The Issuer Identifier for the OpenID Provider (which is typically obtained...

I'm also not aware of any diff functions in erlang like a myers diff. We would have to do that by hand I think. But that also goes further than...

Hm, If it is in telemetry, people will probably not see it. Also, I would like to not log in the core functions itself. But we could add some code...

@MarcelBochtler I added a test to test the deduplication. Running the same test on `main` will cause duplicated information. `$ ./gradlew scanner:funTest --tests "org.ossreviewtoolkit.scanner.scanners.ScannerIntegrationFunTest"` ``` Parallel Configuration Cache is an...

The code can be seen in action here: https://github.com/elixir-lang/elixir/actions/runs/16086802339/job/45398947306 (See the Action Artifacts for Details)

This was already addressed in #406 but is unfortunately not yet released. Will do one once I’m back from my vacation.

Oh, sorry. Reopening. A PR would be welcome 😊