Jonatan Männchen
Jonatan Männchen
@izelnakri Actually it's the other way around: https://github.com/izelnakri/paper_trail/blob/main/lib/paper_trail/multi.ex#L51 ``` Map.get(changeset, :data, changeset) |> Map.merge(%{ id: get_sequence_id(changeset) + 1, first_version_id: version_id, current_version_id: version_id }) ``` `get_sequence_id` does not work with models...
@izelnakri I think we'll find a way that uses the current config with a deprecation warning.
@lukaszsamson Both Phoenix & Phoenix Live View are going to expose Source Maps starting from the next release. * phoenix: https://github.com/phoenixframework/phoenix/pull/4276 (already merged) * phoenix_live_view: https://github.com/phoenixframework/phoenix_live_view/pull/1502 (will be merged soon)...
~~@lukaszsamson Do we need inline source maps? Normal sourcemaps with a reference comment in the js should work as well, no?~~ Edit: never mind, we're loading it inline...
@warmwaffles I've rebased and it seems the tests are failing again. I've spent more time now rebasing this PR than writing it. I would welcome it if a maintainer makes...
@whatyouhide I‘ll do that 👍 No, the official way fur fuzzy is the fuzzy flag. The pipe comment signals the previous mesage. If I extrat the string Hello World and...
@whatyouhide Yes, the `#|` syntax is official. See: https://www.gnu.org/software/gettext/manual/html_node/PO-Files.html > ``` > white-space > # translator-comments > #. extracted-comments > #: reference… > #, flag… > #| msgid previous-untranslated-string >...
@whatyouhide I'll add that in next week :+1:
@whatyouhide Yes and no: The repo is able to parse the headers and accurately choose the correct plural form based on that. It is however not a complete solution yet...
@whatyouhide The current plural behavior exposes only the locale as an argument. To use the plural form parser, it would need the plural forms header as well. Agreed on the...