Mads R. B. Kristensen

Results 162 comments of Mads R. B. Kristensen

> @madsbk Would you please share the status of this work? Are you planning to include AWS C++ SDK changes in 24.12? The plan is to use libcurl instead of...

> This PR probably needs to update `build.sh`. Also check the `libkvikio-tests` [conda packaging](https://github.com/rapidsai/kvikio/blob/branch-24.10/conda/recipes/libkvikio/meta.yaml#L95) and [install script](https://github.com/rapidsai/kvikio/blob/branch-24.10/conda/recipes/libkvikio/install_libkvikio_tests.sh) to make sure we aren't missing anything there. For now, I think `build.sh`...

/merge

> Devil's advocating: couldn't we implement this using `failure_callback_resource_adaptor`? The callback just needs to know about the alternate MR. Not as-is. The callback function in `failure_callback_resource_adaptor` returns a boolean thus...

> Mostly doc comments. However also needs C++ tests. Added C++ tests

Let's put this on hold until we get some more use cases.

> > Ah, this is a nasty gotcha. `pread` doesn't hold a reference to `buf`, so you allocate `buf` in your `pread_one` function but it is dropped by the time...

> I would instead suggest that what we want is to also submit the gather_tasks lambda to the pool and use one of the pool's threads to cycle and check...