Mads R. B. Kristensen
Mads R. B. Kristensen
> Likely they need to be included in the `package_data`? Yes, similar to how we handle `*.pxd`: https://github.com/rapidsai/cudf/blob/branch-22.10/python/cudf/setup.py#L149
Overall, I agree with both of you, my concern with `classmethods` arise when we want to switch to other Buffer types seamlessly. For example, in #10746 we want `as_bufer()` to...
Another design issue I like to discuss is how we support `Buffer` sub-classes like `SpilleableBuffer` that will be implemented in Cython since [Cython classes cannot inherent from Python classes](https://cython.readthedocs.io/en/latest/src/userguide/extension_types.html#subclassing). I...
> I think this needs some thought. Do you envisage that SpillableBuffer vs Buffer will be a global configuration switch, or do you think that you'll want buffer creation to...
Thanks all for your suggestions. I am moving forward with the `Protocol` approach, which means: - We now have a new protocol `DeviceBufferLike`, which `Buffer` implements. - `as_buffer()` has been...
Thanks for the reviews, I think I have addressed all of them?
@shwina What do think of creating a `utils/config.py` module instead `utils/string.py` https://github.com/rapidsai/cudf/pull/11447#discussion_r942147374 ?
> > Thanks for the reviews, I think I have addressed all of them? > > Sorry, I had some still in-flight No worries, I think I have addressed them...
@vyasr do you have anything?
@brandon-b-miller do you have anything more?