Madelyn Olson

Results 445 comments of Madelyn Olson

Reading this again now, I might have totally misunderstood the suggestion. Is the proposal just to support a secondary port who also puts commands on the same main event loop?...

> does this https://github.com/redis/redis/pull/13141 can somehow solve your problem? I really don't understand why Oran marked that as not a breaking change, it's possible someone had more than 128 errors....

I like the idea of tracking lua errors in a separate RAX, however it can't just be based off of `scriptIsRunning`, since the script could generate normal error messages. I...

> If we go down this path, we would have to create a dedicated errorstat section just for scripts `( errorstat_script_*` I don't like this approach. I don't think we...

> We could pass a flag to it to differentiate custom lua errors? Yes. They could be emulating a normal error though.

> I think the difficulty here is how many error codes we can allow the script to customize. The scenes I have seen so far are all misuse, maybe there...

The best way is probably to do a `git rebase -i HEAD~14`, squash all the commit together, sign just the last one, and force push over what you have.

All the updates LGTM feel free to update them further if you like.

@bjosv Does this seem right to you?

I'm not the biggest fan of PR templates, I find them more useful for automation than anything else, but happy to hear what other folks think.