valkey
valkey copied to clipboard
Migrate ziplist.c unit tests to new framework
Issue #428.
Moved the SERVER_TEST block from ziplist.c into unit tests in test_ziplist.c. I left the benchmark related tasks alone in their own test, as I am not sure what to do with them.
Some of my assertions are a little vague/useless, but I will try to refine them.
Looks like I may also need to add a test that does pop() and another for createIntList(), since I did not add that back.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 69.67%. Comparing base (
efa8ba5
) to head (240c42f
). Report is 6 commits behind head on unstable.
Additional details and impacted files
@@ Coverage Diff @@
## unstable #486 +/- ##
============================================
- Coverage 69.77% 69.67% -0.11%
============================================
Files 109 109
Lines 61801 61801
============================================
- Hits 43120 43057 -63
- Misses 18681 18744 +63
Files | Coverage Δ | |
---|---|---|
src/server.c | 88.60% <ø> (ø) |
|
src/ziplist.c | 15.17% <ø> (ø) |
Yikes, I'm not sure how to fix this signing issue. I tried the rebasing instructions, but the result did not look right...
The best way is probably to do a git rebase -i HEAD~14
, squash all the commit together, sign just the last one, and force push over what you have.
All the updates LGTM feel free to update them further if you like.