Esteban Gehring
Esteban Gehring
@hrobertson sorry, this was overlooked, but also its non-trivial to review. it would make it easier and quicker to review if - we could split the PR into several parts...
> If possible, would it be possible for you to review the proposed revisions in response to the points raised? sure, just ping me when the PR is updated
@ksvirkou-hubspot thanks for the fix! @joscha thanks for investigating and preparing the final PR. all merged.
thanks for pointing this out and fixing!
Thanks for the explanation!
This PR resolves https://github.com/swagger-api/swagger-codegen/issues/7638
I agree with @JFCote that it is better to have the getter naming customizable. It is even more important since some property mappers do not map `Boolean isMyVariable()` but only...
i guess that the typescript-angular and typescript-fetch ones are the most popular variants judging from PR frequency, so I would make stringEnums=true the default to keep the non-breaking change behavior...
@simon-abbott yes sorry i meant `stringEnums=false`. can you also make sure to consolidate with https://github.com/OpenAPITools/openapi-generator/pull/18531? what do you propose as the way forward?
@simon-abbott so my question was how you suggest to consolidate with https://github.com/OpenAPITools/openapi-generator/pull/18531.