Esteban Gehring comments

Results 171 comments of


                                            Esteban Gehring

[FIX][typescript-fetch] Fix self import for models with a discriminator

@GeroSchaarmann do you want to fix the conflicts?

[FIX][typescript-fetch] Fix self import for models with a discriminator

@joshuamolden you can e.g. clone this PR and fix the conflicts to move this forward

Module not found NgxMatSelectSearchModule on jest running.

@Tayyba23 can you check whether this is still an issue with version 6.0.0?

[BUG] issue on select when add this control in the for loop

can you please post your template/controller code? it sounds like you are re-using a variable across the multiple instances of the select/search field

Accessibility Challenge in 'Single Selection with Option Group': Inability to Type and Select Matching Option

@zombaki thanks for reporting! Do you want to propose a fix?

[FEATURE] Dynamic default labels for MatSelectSearchOptions

@domestack do you want to implement this?

[FEATURE] Show noEntriesFoundLabel with an empty/none mat-option

@melroy89 do you want to introduce a new `@Input` and use it here? https://github.com/bithost-gmbh/ngx-mat-select-search/blob/da14301066260e1e9c2fbbcf9665986d604b1d2b/src/app/mat-select-search/mat-select-search.component.ts#L596

[FEATURE] Show noEntriesFoundLabel with an empty/none mat-option

@melroy89 yes i think thats what you can achieve by adding an `@Input() additionalOptionOffset = 0;` and using it in https://github.com/bithost-gmbh/ngx-mat-select-search/blob/da14301066260e1e9c2fbbcf9665986d604b1d2b/src/app/mat-select-search/mat-select-search.component.ts#L596 i think thats safer than checking for options without...

Clear search input fix

Its unclear to me why this is needed. @pavelpugachh can you elaborate the scenario this fixes?

Clear search input fix

@pavelpugachh thanks for the explanation. i would suggest to move the check to the _reset method, wdyt?