maciektr
maciektr
@dylanjha I think that node based crypto (https://www.npmjs.com/package/jsonwebtoken) may not work as well.
*[`crates/cairo-lang-syntax/src/attribute/consts.rs` line 39 at r1](https://reviewable.io/reviews/starkware-libs/cairo/5440#-Nvk9bhn8MvcK9EHawo_:-NvkkRDJ6n4dWQfx2e3X:b3gpjw1) ([raw file](https://github.com/starkware-libs/cairo/blob/da783ff56f7d21725755a8144cce171f843571fa/crates/cairo-lang-syntax/src/attribute/consts.rs#L39)):* Previously, orizi wrote… so rename to something longer and more cumbersome - for example: `execution_entrypoint` if a test will create such a thing...
*[`crates/cairo-lang-compiler/src/lib.rs` line 150 at r2](https://reviewable.io/reviews/starkware-libs/cairo/5440#-NvkusDMCcQBECmm0JoV:-NvlN1SfDmmu91S-6rea:b-1lo195) ([raw file](https://github.com/starkware-libs/cairo/blob/ae04675d17452cb183bd74fb81f275f567ce0a44/crates/cairo-lang-compiler/src/lib.rs#L150)):* Previously, orizi wrote… i think maybe this function should just not exist. and similarly to how we call `compile_contract_in_prepared_db` which is contract aware,...
Previously, orizi wrote… the idea is - same as test plugin that knows what are the relevant functions (so it can fill the artifacts) and the starknet plugin, so can...
Previously, orizi wrote… but this means that things like tests would need to rewrite their code - we probably don't want that as well Hmm, I am not saying we...
Ok, thanks so much for elaborating, it makes a lot more sense to me now! > i was talking about all plugins requiring rewriting their code for this to capture...
> the artifacts should IMO be guided by the caller - instead of by annotation that will need to be added in all cases in the world Do you think...
*[`crates/cairo-lang-sierra-generator/src/executables.rs` line 61 at r1](https://reviewable.io/reviews/starkware-libs/cairo/5440#-NvkPznlE57ycHoOwh86:-NwOaNXNBHmhEJ6G1gW2:bpgwvvw) ([raw file](https://github.com/starkware-libs/cairo/blob/da783ff56f7d21725755a8144cce171f843571fa/crates/cairo-lang-sierra-generator/src/executables.rs#L61)):* Previously, mkaput (Marek Kaput) wrote… Retracting because I have a better idea. No longer relevant.
*[`crates/cairo-lang-sierra/src/debug_info.rs` line 41 at r1](https://reviewable.io/reviews/starkware-libs/cairo/5440#-NvkPjOXE6rVBEO36P7U:-NwOaTON3fA4hagL1PTU:b-896fix) ([raw file](https://github.com/starkware-libs/cairo/blob/da783ff56f7d21725755a8144cce171f843571fa/crates/cairo-lang-sierra/src/debug_info.rs#L41)):* Previously, mkaput (Marek Kaput) wrote… We're iterating the structure of this field internally/offline. Done.
*[`crates/cairo-lang-defs/src/plugin.rs` line 112 at r6](https://reviewable.io/reviews/starkware-libs/cairo/5440#-NwdTVFG9BxIq3Gv_m9F:-NwdXFNZAdah_r2_gunr:b-896fix) ([raw file](https://github.com/starkware-libs/cairo/blob/2704f82389968232d884b91bfe575a50a0c55bcd/crates/cairo-lang-defs/src/plugin.rs#L112)):* Previously, mkaput (Marek Kaput) wrote… It doesn't make sense to return `vec::IntoIter` here. Return an owned `Vec` (you'll boil down to the same...