Mehdi Achour comments

Results 282 comments of


                                            Mehdi Achour

trafficstars

fix(sessions): use atomic writes for file storage

Hi @midgleyc and thank you so much for tackling this. Please rebase this PR on the `dev` branch

<PrefetchPageLinks /> crashes the page when there is a query param in the URL

Verified on 1.6.4 as well

`@remix-run/web-fetch` causes tests to error after upgrade to jest 28

@penx is this still a problem for you?

feat(templates): add Link header for Early Hints, HTTP2 Server Push etc.

Hi @Plopix and thank you for opening this PR! Can you target the `dev` branch instead as you're changing code?

Cloudflare's Rocket Loader make hydration fail in firefox

Hi @atouchsimo, is there any way you can provide a public repository reproducing this issue? Hard to say what's going on exactly here except that `useRemixEntryContext()` returned an undefined `routeModules`...

Cloudflare's Rocket Loader make hydration fail in firefox

You seem to be using Cloudflare, I wonder if turning off the 'Rocket Loader' under speed optimizations would solve your issue (see https://github.com/remix-run/remix/issues/1618#issuecomment-1113887894)

Cloudflare's Rocket Loader make hydration fail in firefox

Excellent. Took the liberty to rename your issue to see if we can fix this somehow on our end. It seems that we should be adding `data-cfasync="false"` on our scripts...

[Bug]: Layout route with more than one pathless layout causes invalid conflict

Will be fixed by #4421

feat(remix-server-runtime): add loader context generic types

Hi @rwu823 and sorry for the delays. Can you rebase your PR to target the dev branch?

bug(remix-react): add failing test for scroll-restoration

@Mattinton could you please sign the CLA?