remix icon indicating copy to clipboard operation
remix copied to clipboard

bug(remix-react): add failing test for scroll-restoration

Open matt-kinton opened this issue 3 years ago • 5 comments

Page scroll should be at the top on the new page

matt-kinton avatar May 12 '22 11:05 matt-kinton

Hi @Mattinton,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].

Thanks!

- The Remix team

remix-cla-bot[bot] avatar May 12 '22 11:05 remix-cla-bot[bot]

@Mattinton could you please sign the CLA?

machour avatar Sep 03 '22 14:09 machour

⚠️ No Changeset found

Latest commit: 958ef096eaa1e01e99447849fc950c0014694ea9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Sep 03 '22 15:09 changeset-bot[bot]

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

remix-cla-bot[bot] avatar Sep 03 '22 15:09 remix-cla-bot[bot]

@Mattinton could you please sign the CLA?

Sorry thought I'd done it already but turns out it was a different PR. Done.

matt-kinton avatar Sep 03 '22 15:09 matt-kinton