Ayoub Mrini

Make DBReadOnly more RO

7

Fixes: https://github.com/prometheus/prometheus/issues/11618 https://github.com/prometheus/prometheus/issues/8086 The RO head could alter the mmap chunks while replaying the WAL e.g. https://github.com/prometheus/prometheus/blob/e6d3d6abd99d1eda8576809b62d59d606ee1d5ac/tsdb/head_wal.go#L594 The other possibility is if it tries to repair a chunk file in...

improve --rules.max-concurrent-evals description.

1

### Proposal Suggest to adjust `–query.max-concurrency` when changing `--rules.max-concurrent-evals` as the rules manager uses the same query engine than the API: https://github.com/prometheus/prometheus/blob/4a6f8704efcabfe9ee0f74eab58d4c11579547be/cmd/prometheus/main.go#L743-L772 Add that to `--rules.max-concurrent-evals`'s description: https://github.com/prometheus/prometheus/blob/633224886a1c975dd3a8a8308a0b1d630048a21c/cmd/prometheus/main.go#L420 Was discussed...

NO REVIEW NEEDED: just for debugging

7

/cc amrini /assign amrini

fix(api): Send warnings only if the limit is really exceeded

2

For the the series, label names and label values APIs Add warnings count check to TestEndpoints The limit param was added in https://github.com/prometheus/prometheus/pull/13396 This fixes https://github.com/prometheus/prometheus/pull/13396/files#r1538010352

Add unit testing for AWS SD

3

### Proposal It seems we’ve been relying on manual testing by maintainers and the community. I'm lacking context regarding this. I don't think I need to explain the necessity of...

Promote new-service-discovery-manager

2

### Proposal `new-service-discovery-manager` has been introduced in https://github.com/prometheus/prometheus/pull/9349 and https://github.com/prometheus/prometheus/pull/9537, it's hidden behind `--enable-feature=new-service-discovery-manager`. I expect this new manager to be widely adopted by third parties (consumers that use prometheus...

### Proposal The DNS lookup issues, for example, are considered "recoverable" issues. https://github.com/prometheus/prometheus/blob/6572b1fe631e00440a2c682f8f966232f697d358/storage/remote/client.go#L223-L227 and are endlessly retried https://github.com/prometheus/prometheus/blob/c5040c5ea9e70b6525cd6942fb26a1bdb32510d6/storage/remote/queue_manager.go#L1673-L1677 Logs like the following are emitted: ``` ts=2024-06-14T01:28:01.804Z caller=dedupe.go:112 component=remote level=warn remote_name=5ca657...

[Feature]: Rethink ListOptions for a more intuitive and natural interaction

2

### Description Despite what one may think when encountering `ListOptions`, it's not that immutable input that would only be used to pass options. It's also used, for example, to track...

chore: update min go version to 1.22 and update to the 1.23 toolchain

8

enforce the go version in test_go_oldest through `GOTOOLCHAIN=local`.

test(tsdb): add a reproducer for https://github.com/prometheus/prometheus/issues/14422

5

"a block that was being queried by the read API was able to get closed because it had no `pendingReaders`"