Ayoub Mrini

Results 46 issues of Ayoub Mrini

See https://github.com/prometheus/prometheus/issues/12858#issuecomment-1812193655 for details (will add that to the commit message) I added a test that reproduces: https://github.com/prometheus/prometheus/issues/12858#issuecomment-1732318102 and it's failing with the code in main: https://github.com/prometheus/prometheus/actions/runs/6876250042/job/18701456148?pr=13147#step:6:378 I pushed a...

…still be logged. Fixes https://github.com/prometheus/prometheus/issues/11574

… in RoleEndpointSlice This was due to a missing "return", see https://github.com/prometheus/prometheus/pull/13554#discussion_r1490965817

Fixes https://github.com/prometheus/prometheus/issues/13305 Needs https://github.com/prometheus/prometheus/pull/13554 - ~~[ ] Benchmark~~

This closes the loop, as the output can be fed into "tsdb create-blocks-from openmetrics" Native histograms are not supported. Fixes https://github.com/prometheus/prometheus/issues/12022

Addresses https://github.com/prometheus/prometheus/issues/8278 Next steps: - [x] Look at the mmapHeadChunks starvation. See: https://github.com/prometheus/prometheus/pull/12532#issuecomment-1855622480 - [x] Decide on the offset boundaries - [ ] this would increase the `minValidTime` by `offset`...

Run test_mixins on the latest golang version From https://github.com/prometheus/prometheus/pull/13389#pullrequestreview-1822015642

#### Describe the feature The `containsValue(name, value, ...)` method in [HeadersMultiMap](https://github.com/eclipse-vertx/vert.x/blob/244b91045bb166625b2645bfdc95ede825c133a3/src/main/java/io/vertx/core/http/impl/headers/HeadersMultiMap.java#L226) is meant to check the existence of a value in a multi values key/header. I'll be useful to expose...

enhancement

…probes when ListenLocal is set as Prometheus listens on 127.0.0.1:9090 in that case. Here: https://github.com/prometheus-operator/prometheus-operator/blob/48d3604507e082f4187f39edda9bc22935881a14/pkg/prometheus/statefulset.go#L242-L243 This avoid a first IPv6 name resolution attempt (for curl at least) that always fail....

stale
size/XS

After https://github.com/prometheus/client_golang/pull/1143, the function `testutil.GatherAndCompare`: https://github.com/prometheus/client_golang/blob/1bae6c1e6314f6a20be183a7277059630780232a/prometheus/testutil/testutil.go#L197-L203 https://github.com/prometheus/client_golang/blob/1bae6c1e6314f6a20be183a7277059630780232a/prometheus/testutil/testutil.go#L205-L222 https://github.com/prometheus/client_golang/blob/1bae6c1e6314f6a20be183a7277059630780232a/prometheus/testutil/testutil.go#L236-L245 became error-prone, as we filter the `expected` metrics in `compareMetricFamilies` as well now, if we make a mistake in one of the...

bug
help wanted
stale