Sally MacFarlane
Sally MacFarlane
Getting 3 errors from running `./gradlew :tests:acceptance-test:compileTestJava` locally - to do with something I don't understand in module-info.test ``` /Users/sallymacfarlane/workspace/tessera/tests/acceptance-test/src/test/java/db/HsqlDatabaseServer.java:4: error: package org.hsqldb.persist is not visible import org.hsqldb.persist.HsqlProperties; ^ (package...
with extra work I am down to one error ``` /Users/sallymacfarlane/workspace/tessera/tests/acceptance-test/src/test/java/db/HsqlDatabaseServer.java:4: error: package org.hsqldb.persist is not visible import org.hsqldb.persist.HsqlProperties; ^ (package org.hsqldb.persist is declared in module org.hsqldb, which does not...
^ so in test we are using a class org.hsqldb.persist.HsqlProperties which is not exported by the org.hsqldb module - not sure if there's a way around this
luckily there is an overloaded method that accepts java.util.Properties and wraps them into HsqlProperties internally.
2.7.1 is out so suppression can be removed
current failures seem to boil down to this ``` Error occurred during initialization of boot layer java.lang.module.FindException: Module jnacl not found, required by tessera.encryption.jnacl ```
Any reason not to merge this one @jflo @diega ?
ran up a node on AWS with this and logging appears normal ``` {"@timestamp":"2022-11-14T01:07:05,189","level":"INFO","thread":"EthScheduler-Services-34 (importBlock)","class":"FastImportBlocksStep","message":"Completed importing chain segment 707401 to 727600 (20200 blocks in 10022ms), Peers: 4","throwable":""} {"@timestamp":"2022-11-14T01:07:15,768","level":"INFO","thread":"EthScheduler-Services-34 (importBlock)","class":"FastImportBlocksStep","message":"Completed importing...
Hi @JosephK95 I'm taking a look at this - agree with @daniellehrner the spec is a little vague - and at the same time consistency is generally good. Further analysis...
@jflo can we call this done?