Sally MacFarlane

This log line comes from here https://github.com/hyperledger/besu/blob/5e0301a749ac49a611a26c1df84eee5c0ee198f6/ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/sync/tasks/PersistBlockTask.java#L226 Not sure how/why it would exceed the number of peers available. We can aim to add some more testing around this method.

We have observed the same behaviour. When admin_peers details are examined, the discrepancy is that we have two peers that are identical, except that one has ?disc_port=0 @RP27 Have a...

Repo with minimal reproduce instructions https://github.com/macfarla/besu-duplicate-peers

and I just ruled out IBFT2. I get the same thing with ethash.

It looks from the logs like both nodes are detecting the duplicate connection and initiating disconnect. maybe there's a race condition there.

Next steps - clean up logging on #4001

Hey @emclab we are still working on fixing the root cause here, but we think some other improvements that have been made elsewhere in peering may have reduced the incidence...

Reported by a user on 22.7.0 on mainnet https://discord.com/channels/905194001349627914/1006351975467728916

After a few days running on goerli besu 22.7.0 ``` [TRACE] 2022-08-15 00:32:32.646 [nioEventLoopGroup-3-9] EthProtocolManager - 20 EthPeers { PeerId 0x14601ba2d78d81d8fac9ee735cc3a4c1e49939f987adc21a6e0a391ec688a22601cc7030e5a2e9ad64ebc5e1aeb8b9dec1ccedefe041ced9614c1af6d38ee0b6, reputation PeerReputation 100, validated? true, disconnected? true, client: besu/v21.1.4/linux-x86_64/openjdk-java-11,...

#4304 should help with this issue