Sally MacFarlane

Results 310 comments of Sally MacFarlane

@pullurib there's a compile error that needs fixing before this can be reviewed in detail

> @macfarla Sorry lost track of this . I spent time looking into it but adapting fastsync to snapsync is not a trivial change to include in this PR ....

@alex123012 there's a couple of unit tests failing. you should be able to reproduce locally > Task :besu:test BesuCommandTest > natManagerServiceNameCannotBeUsedWithNatDockerMethod FAILED java.lang.AssertionError at BesuCommandTest.java:1971 BesuCommandTest > natManagerServiceNameCannotBeUsedWithNatNoneMethod FAILED java.lang.AssertionError...

code looks ok - @alex123012 how would I verify that it's working? new to kubernetes

@alex123012 to simplify besu codebase we are planning to deprecate k8s NAT method, so we are reluctant to make changes to it at this stage. Suggestion from our devops team...

@alex123012 are you still engaged on this PR? it's marked as stale and will be closed in 2 weeks if no activity

Hi @alex123012 We have made the decision to deprecate k8s with nat manager. So we don't want to add to this section of the code base. We've got solutions in...

@cryptohazard to clarify - you're asking for a metric for this? you're welcome to do a PR :)

> Hi @alanpaxton @adamretter , Do you have any plans to merge this PR and include it in a future release ? We're experiencing the same issue as #13023 from...