Sally MacFarlane
Sally MacFarlane
this change breaks the minimalist-staker profile with the message --bonsai-historical-block-limit minimum value is 512 minimalist-staker profile has it set to 128 check is done [here](https://github.com/hyperledger/besu/blob/61c7e18ab446a7383bafc2e10d96a88595cf1986/besu/src/main/java/org/hyperledger/besu/cli/options/stable/DataStorageOptions.java#L113) with trie-log-limit enabled = false...
actually went the other way in the PR - changed minimalist-staker limit from 128 to 512
(won't be a breaking change if we want to go the other way in the future)
nope, changed again. minimum = 128 and default = 512
may be some context here https://github.com/hyperledger/besu/pull/2970
I think you could reproduce by starting a goerli node, watching for disconnects and then calling admin_addPeer with an enode that's been disconnected. to use admin_addPeer you need to enable...
Hi @NickSneo - would like to see some unit and acceptance tests for this new method!
this will be addressed as part of the larger sync refactor
@ahamlat is this PR one you're going to come back to or is the outcome to go with a different approach?
Blocked by #6609 - without that we would disconnect peers, because we are trying peers that do not serve snap data.