Sally MacFarlane

Results 208 comments of Sally MacFarlane

@lyfsn I'd like to get this merged in! but only you can update the branch

> @macfarla Every time I update the code to the latest version, I need to restart the CI checks. Is this a normal process? Because this means that the entire...

also LondonFeeMarketBlockTransactionSelectorTest eg https://github.com/hyperledger/besu/actions/runs/8534378846/job/23378859930?pr=6870

reasons for disconnects (inbound and outbound) with holesky bootnodes (running #6609 built from source) ``` ➜ ~ grep 0xa3435a0155a3e837... disconnects-6609* disconnects-6609-51.log:{"@timestamp":"2024-04-15T04:58:56,490","level":"DEBUG","thread":"nioEventLoopGroup-3-4","class":"EthProtocolManager","message":"Disconnect - active Connection? true - Outbound - 0x01 TCP_SUBSYSTEM_ERROR...

Further analysis from 2 sets of 3 holesky nodes 3 nodes 6609-90,6609-91,6609-92 - (running some variation of #6609) all 3 got almost in sync and then disconnected the bootnodes for...

and then I started 6609-00, 6609-01, 6609-02 This time the bootnode disconnects are all TCP_SUBSYSTEM, and it seems the root cause is Connection reset `"DeFramer","message":"IO error while processing incoming message","throwable":"...

since they both had zero peers, on 6609-00 and 6609-02 I forcibly added (using admin_addPeer) the 2 holesky bootnodes as peers. So now besu will try to reconnect even if...

maybe this is fixed by something in main - haven't seen this on any burn in nodes

also maybe some context in #5785

Actually #7007 was a different flake, in the same test. NodeSmartContractPermissioningOutOfSyncAcceptanceTest > addNodeToClusterAndVerifyNonBootNodePeerConnectionWorksAfterSync() FAILED org.awaitility.core.ConditionTimeoutException: Assertion condition defined as a org.hyperledger.besu.tests.acceptance.dsl.AcceptanceTestBase Expecting actual: 22 to be greater than or equal...