Marc-Stefan Cassola

Results 107 comments of Marc-Stefan Cassola

Also fixes #5456 because I thought this tiny change didn't warrant a separate PR

> > Also fixes #5456 because I thought this tiny change didn't warrant a separate PR > > Can you split this out? I see your point, but it'll keep...

> > If they're different units it becomes undefined > > I don't know if I like that idea. It seems _very_ prone to cause hard to find bugs. I'd...

Also while we're at it, if I remember correctly from my CSS Flexbox experience, the default value for a flexbox is `auto`. So this kind of would make `undefined ==...

I added the docs for now. Let me know if I need to add warnings and where or whatever the decision is.

I mean people can always manually take out values from pixel and percent and do whatever they want to them. No way of preventing that. But ok I’ll add warnings...

webp has mainstream support in Browsers and has transparency as well as animation. So it would be awesome if there was an option to use it!

Hey @JoshK2, thanks for your reply. Here is a zip with the source code in question. I'm using typescript compiler 3.1.28 and karma-mocha tester 1.7.1 [Archive.zip](https://github.com/teambit/envs/files/4063866/Archive.zip)

> @maccesch just to clarify a bit, when I say that number 4 is unacceptable. Your PR was completely fine based on the issue description and I don't want you...

lol my first PR to Bevy already went from good first issue to controversial to closed 🤣