Maciej Brencz

icon indicating a website link http://stackoverflow.com/story/macbre icon indicating an email [email protected]

icon company @automattic icon location Internet icon location I enjoy investigating how software works under the hood (this also includes situations when software does not work and has to be fixed)

Results 130 comments of Maciej Brencz

wait-for-selector not working on some pages

@gmetais, thanks for the investigation. I"ll try to refactor the test to be more deterministic and work across platforms.

Any recommendations on importance of metrics

Great idea! There is already a JSON file with metrics metadata, but adding `importance` field for each metric would be definitely a killer feature.

Any recommendations on importance of metrics

I'm totally for this idea, no irony intended :) However, I see it more as a long lasting "project". Marking 100+ metrics with a propery "priority" / "importance grade" will...

Test failed - request throttled by proxy. Is it possible to add custom header to a config?

Good idea! - First, you can take a look at a `userAgent` extension on how to handle options and customise puppeteer run. https://github.com/macbre/phantomas/blob/devel/extensions/userAgent/userAgent.js - And use puppeteer API to set...

Add JUnit output format

@rbayliss, if you feel like preparing a PR, that would be great :)

How to clear the localstorage after a single run?

Waiting for https://github.com/ariya/phantomjs/pull/404

Analyze images size

Tools to consider: - [cwebp](https://developers.google.com/speed/webp/docs/cwebp) - [mozjpeg](https://github.com/mozilla/mozjpeg/blob/master/usage.txt) - [pngcrush](http://pmt.sourceforge.net/pngcrush/)

sql-metadata does not understand VALUES Lists constructs

@collerek - you're right, this does look more like an enhancement then a bug.

Handle when column name wildcard is prefixed by table name

@sumartoyo, thanks for your PR. Please add a test case(s) that cover your changes. Then we'll review your pull request. ``` FAIL Required test coverage of 100.0% not reached. Total...

Handle when column name wildcard is prefixed by table name

@sumartoyo, `black` formatting tool is complaining. And linting does fail. Please fix these and we'll review your changes. Thanks!