Maciej Brencz

icon indicating a website link http://stackoverflow.com/story/macbre icon indicating an email [email protected]

icon company @automattic icon location Internet icon location I enjoy investigating how software works under the hood (this also includes situations when software does not work and has to be fixed)

Results 130 comments of Maciej Brencz

Slimmer Phantomas with a plugin/extension model

After running the following I'm even more for it :) ``` macbre@debian:~/github/phantomas$ du -hs node_modules/ 202M node_modules/ ```

Slimmer Phantomas with a plugin/extension model

@EFF thanks x3! As for the `phantomas-reporter-cloudwatch`: [the package is on npm](https://www.npmjs.com/package/phantomas-reporter-cloudwatch), I guess we can now remove this reporter (and its dependency) from the main phantomas repo.

Slimmer Phantomas with a plugin/extension model

@EFF, I might have misunderstood the point of this ticket, but shouldn't we exclude `phantomas-reporter-cloudwatch` package from `package.json`? If someone wants to report to cloudwatch, then just run `npm install...

Slimmer Phantomas with a plugin/extension model

No worries, we're on the same page now :)

SPOF checker

Check [onPageCreated event](https://github.com/ariya/phantomjs/blob/master/src/modules/webpage.js#L232) to get HTML received from server (with no changes from JS).

SPOF checker

Waiting for https://github.com/ariya/phantomjs/pull/11484 to be able to get not modified HTML of the page (i.e. without any changes done by JavaScript code)

SPOF checker

Waiting for #313 - SlimerJS provides content of HTTP responses

SPOF checker

I'd rather use SlimerjS' ability to provide response's body.

Multiple Runs Results in: TypeError: Bad argument

> I installed some local dependencies What were these dependencies?

Multiple Runs Results in: TypeError: Bad argument

@xiuhonglee, are there any debug log messages emitted before the error shows up? Please provide npm and nodejs version. Are you installing from npm or cloning git repo?