Mac Gainor

Results 63 comments of Mac Gainor

i noticed an issue with collapsed strings: ![image](https://user-images.githubusercontent.com/4097374/107171671-36202380-6978-11eb-8636-8e2693b9e261.png) color strings get collapsed but expanding them doesn't work. you can see this in the first example on your branch if you...

I love this idea, thanks again for posting i think there are a couple of things that should happen before this gets merged and published: 1. add at least one...

@AtlHermanChow thanks for posting this. i like the idea. discussing with @imdanielsp ... might be able to get this live + deployed this weekend. sorry about the delay, this project...

@dyennam thank you for brining this up. when a user clicks to expand or collapse, expand/collapse state is introduced within RJV. this is intentional given the way the component is...

@janryWang can you give an example of how you want to be able to sort differently?

not a bad idea. i'm open to reviewing pr's that implement this.

good question. I'm not sure how you would go about doing that at the moment. what do you think would be a good way to do it? maybe RJV could...

yea, I could add something like that. it would be a custom style callback. so, given property name, namespace and value, you can apply custom values. I'll re-purpose this issue...

@paulmichaelxd thanks for the feedback. I'm willing to support the custom style feature and I welcome PR's. I think it's possible to implement the custom collapse behavior via the `shouldCollapse`...

@paulmichaelxd thanks for pointing me toward the react-json-tree example. I like what they're doing with style customization. I'll take a closer look at what it would take to support something...