Mazen

Results 15 comments of Mazen

Thanks, @MagedSaeed, for the feedback! ## Restructuring the project - I am planning to keep the current structure in the first stage of refactoring so we can enable unit testing...

That sounds like a good plan! I will start working on the refactoring `klaam` and make a PR for that.

https://github.com/ARBML/klaam/pull/21 summary: - Restructured the repo per this issue - Added `pre-commit` to ensure the quality of commits to follow the best practice - Added a CI to run tests...

I have implemented Siamese Network example in this PR https://github.com/pytorch/examples/pull/1003

I suggest closing this issue as #1003 has been merged to master. Thanks, @msaroufim for the feedback! --- I can make another example that aligns with what the issue is...

I have encountered this issue and here is a [Colab notebook](https://colab.research.google.com/drive/11gBgDQC0en-5-kMBmSFN0ubV3ylILZKF?usp=sharing) to replicate the issue and the solution. I agree with @FeryET, the setup is confusing and it would be...

This issue will be moved to another release.

#68 covers the page highlighting updates, however, it will be nice to have a notification window when a new release has been published on the website and the user isn't...

The changelog has somewhat structured data. ``` ## [version_num] - YYYY-MM-DD ### Added - TEXT - TEXT - ... ### Changed - TEXT - TEXT - ... ### Fixed -...

I was thinking of having a modal to pop-up this if the user didn't see the update before with something like this: ![](https://preview.redd.it/bn74jszjnuo61.png?auto=webp&s=70e2678915dde72e19e5d2b12e172b96b360e6da) But if you think a simple highlight...