Amin Sadeghi

Results 145 issues of Amin Sadeghi

Many of our methods' arguments include both pore and throat properties, such as `pore_diffusivity` and `throat_diffusivity`. Is that really necessary? I'm proposing, for the benefit of brevity and cleaning up...

discussion
maintenance
api

performance
difficult

The idea is to write a method that serves as a factory for pore-scale models. For instance, let's say you want to use a peculiar rate equation as source term,...

enhancement
discussion
proposal

(similar to what was done for porespy)

maintenance

I know that we didn't promise tech support for our Dragonfly plugin, but maybe updating it so that it works with the latest `porespy`/`openpnm` might not be a bad idea,...

This would eventually add the ability to properly run simulations on part of the network. For starters, though, we could only return a masked array (interleaved with nans at locations...

For now, I've removed `macos-latest` from `tests.yml`. Once it's fixed, needs to be added again.

testing
maintenance

In the Notes section of almost all models (including 3d ones), it says "this model should only be used for 2D simulations, etc.".

documentation

Closes #2207. Here's a working example: ```python import numpy as np import openpnm as op import matplotlib.pyplot as plt Nx = 101 shape = [Nx, 1, 1] spacing = 1/Nx...

I'm not sure if this is already possible in OpenPNM, but the idea is to export the results of a parametric study (e.g., battery simulation at different cell voltages/currents, or...

feature request
difficult