Amin Sadeghi

icon indicating a website link https://ma-sadeghi.github.io icon indicating an email [email protected]

icon company Carbon Engineering icon location Vancouver, Canada icon location Scientific computing, machine learning, software development

Results 145 issues of Amin Sadeghi

_parse_pad_width fails when given list of lists

2 comment

Try with ```pw = [[0, 0], [0, 0], [3, 3]]```.

bug
high priority
easy

Add `volume_fraction` as an optional argument to packing generators

2 comment

discussion

Allow rescaling SNOW based on voxel size

1 comment

Currently, voxel size is passed as an argument to SNOW, meaning that once the network is extracted, it's not possible to easily rescale the output based on a different voxel...

feature request

Parallelize unit tests

2 comment

Similar to PR #463, but for unit tests. Not urgent though, as our unit tests are still manageable.

maintenance
tests

Metrics unittests are failing

https://github.com/PMEAL/porespy/runs/4590324027?check_suite_focus=true

maintenance
tests

Dask progress bars are not compatible with logging

1 comment

I removed Dask progress bars for now (in PR #414). A more permanent solution would be to wait for Dask to fix the progress bar upstream. See dask/distributed#3414.

bug

Issue with the dependencies of `openpnm`

See PMEAL/porespy/issues/714.

`flatdict` is not compatible with Python 3.10+

Update `install_requires` in setup.py

Size factor models return negative numbers for conduits with "engulfing" pores

8 comment

When one pore center lies within another pore, our size factor models break down, including `cones_and_cylinders`.

bug
high priority