m4b
yea, unit maybe could work, but honestly your time is probably spent elsewhere and other features. now that i know about symtab unit, i just know what to look out...
Thanks for fuzzing, I love that! I’m a bit busy but I’ll begin triage on issues little later this week, however for particular case of from_utf8 this is available in...
Actually taking a second look here, I'm a little bit confused what the issue is? Specifically, scroll::Pread on an &str uses this implementation: https://github.com/m4b/scroll/blob/73c1d6764446626593f19422021445c21183698e/src/ctx.rs#L699-L705 (i.e., it calls ::from_ut8 for you)....
Ok sounds good let’s do it!
I'm not sure, since that returns some number someone might use, it could end up not being great? However I'm not sure what it would help by adding a saturating_sub...
@koutheir does this look ok to you?
Some notes: 1. We won't be adding anyhow/thiserror/error library to goblin, probably ever. So if the assumption of these result returning changes is they'll be more usable in a follow...
@anfedotoff i'd be ok with merging this but i think we have to roll back the breaking change to the `find_offset` function; it seems unnecessary to me. If you want...
@anfedotoff Ok that works for me!
I'm only a year late, and many releases since, but I've tagged it now I believe :)