Manu
Manu
I'll try macOS today.
Added for macOS: ``` In [1]: from vorta.keyring import darwin In [2]: k = darwin.VortaDarwinKeyring() In [3]: k.get_password('vorta', 'google.com') In [4]: k.set_password('vorta', 'google.com', 'asdf') In [5]: k.get_password('vorta', 'google.com') Out[5]: 'asdf'...
Rebased and pushed it again. Please be careful with force-push and use it only when really needed.
For macOS-related stuff it's needed because some libraries aren't available on linux (pyobjc). In this case it could be due to circular dependencies. Needs to be reviewed. If no issues,...
> Can you please explain about `test_repo.py`? Well, the main purpose of this PR was to avoid having hundreds of old passwords in our keychain from tests. Since our tests...
https://github.com/borgbase/vorta/blob/master/tests/test_repo.py#L68 https://github.com/borgbase/vorta/blob/master/tests/test_repo.py#L84
Looks good. I just have these concerns: - The assert to test if the password is gone isn't really needed all the time. Just enough to test it *one time*...
Not quite. - The keyring instance you create in the fixture isn't used in the test and Vorta will always make its own. - You wouldn't need to remove the...
Also be sure to rebase your branch sometimes, since the master branch will keep changing when a PR is open for longer.
Repo URL and password are generated by the fixture. The password manager entry is also removed by the fixture during cleanup.