Manu

Results 650 comments of Manu

Makes sense as plugin, which it already is.

Added some comments. I see you need to rely on existing modules. We don't really have that anywhere else. Will be better to try reusing what's already there.

All approved. Hopefully we can count you as contributor soon.

Python 3.6 needed to be removed as required status check in GH Actions settings.

Thanks for contributing some templates! You can check out the [tutorial](https://github.com/invoice-x/invoice2data/blob/master/TUTORIAL.rst) or look at existing templates in this repo. We don't really have style rules for now, but if you're...

Personally I would make a new branch in my own fork while working on any new pull request. After it's done, we'll merge this feature branch into the master branch...

Zugferd is mainly about how the invoice metadata is *embedded*. The actual data structure is specified in CII or UBL. For field names either one could be used. See here:...

(fixed formatting of initial comment) You need to load the template(s) first using the `read_templates()` function. You are passing a string instead, which fails. See the example code on the...

> Use extended fields syntax Defining this per-field makes more sense to me personally and seems more scalable. So we would have options for each field: regex, static, lines plugin,...

This should probably be a parser, if it only finds a single value in a specific area. Difference between parser and plugin: https://github.com/invoice-x/invoice2data/blob/master/src/invoice2data/extract/plugins/__interface__.py#L4