Justin Moeller

Results 99 comments of Justin Moeller

Haven't had time to sufficiently look into this to have an opinion. Why can't the fedimintd endpoint be directly fuzzed instead of the handlers? @NicolaLS let me know if there's...

What do you mean by properly migrate the modules over? I could reduce the scope of the PR if you want, perhaps limiting it to only client changes (but keep...

Yep I can take this over.

DB Dump tool has been added. Closing

> Should we just finish impling this for cln then leave lnd as todo until we write the lnd companion daemon? I don't think that's necessary, we can still implement...

> If we want to continue with the gateway extension concept where third parties can build these I'd rather have a sanity-check inside the gateway to catch any HTLCs we...

Looking pretty good imo, I only had a few more nit comments

Not finished with review yet, but I think one thing that will help (especially to new viewers who are not familiar with the changes between legacy and NG) is to...

Ok I think I made it through all of the code, nice work! :) I believe most of my comments are nits or around naming, or debugging suggestions as I...

From an offline discussion with @tvolk131, we thought it would be a good idea to add a very simple liquidity management API to the gateway, essentially mirroring a similar API...