Miroslav Mitev

Results 40 comments of Miroslav Mitev

Hey @dadish, thanks for pointing that out! After further investigation, I think it should be fine removing that object as you suggested. Here's some more context: The one thing that...

> I don't think you need to keep the `block.json` metadata separately in `metadata` property. You can simply pass the whole thing into registerBlockType function. >```js >blocks.forEach( ( block )...

> Agree, let's keep it. My only concern is that it's not clear from the code why the redundant metadata is needed. A person like me might think it's not...

JFYI, I've updated the target branch to `feature/progress-data-layer-refactoring-stage-2` which points to the previous feature branch.

Should we move the installer classes to the internal namespace?

Hm, do you think it might be useful to other plugins/devs? I just don't see why we would want to expose that and it might prevent us from doing quick...

@Automattic/nexus Could someone review this PR? It should be a quick one. 🙂

Solved the problem by disabling the `CreateCustomerExtension` (not really using it), but maybe that extension shouldn't be that restrictive and allow `ArrayAccess` model instances instead of `ArrayObject`. Here is some...

It might be risky. It is possible for developers to restore the legacy emails. We've only disabled it but didn't deprecate the `Sensei_Emails` class which uses the templates. We've even...