sensei icon indicating copy to clipboard operation
sensei copied to clipboard

Published 20 hours ago • verified publisher icon Automattic

Deprecate old email functionality

Open donnapep opened this issue 2 years ago • 3 comments

Is your feature request related to a problem? Please describe

In Sensei 4.12.0 we shipped new email functionality. This new functionality utilizes the site editor to make customizations and no longer supports overriding templates in the templates/emails folder.

Given this, we should deprecate the old email class and template files.

donnapep avatar Aug 01 '23 11:08 donnapep

@m1r0 I don't think we need to worry about sites that may have overridden the email templates, because when they upgrade, the newer email functionality doesn't utilize those templates anyway, right?

donnapep avatar Aug 01 '23 19:08 donnapep

It might be risky. It is possible for developers to restore the legacy emails. We've only disabled it but didn't deprecate the Sensei_Emails class which uses the templates. We've even added a hook to make it easier to restore it.

My gut feeling is that we should follow the deprecation procedure and deprecate the email class and template files.

m1r0 avatar Aug 01 '23 19:08 m1r0

My gut feeling is that we should follow the deprecation procedure and deprecate the email class and template files.

OK, I'll update this issue to reflect that.

donnapep avatar Aug 01 '23 20:08 donnapep