Yiming Lei comments

Results 6 comments of


                                            Yiming Lei

Detect type mismatch due to loop that might never iterate

@rustbot claim

Detect type mismatch due to loop that might never iterate

do we need to duplicate the statement of loop to emit more information? How about the output like this? ``` error[E0308]: mismatched types --> src/lib.rs:2:5 | 1 | fn foo()...

Detect type mismatch due to loop that might never iterate

now the output looks like: ``` error[E0308]: mismatched types --> main.rs:2:5 | 1 | fn foo() -> i32 { | --- expected `i32` because of return type 2 | /...

Detect type mismatch due to loop that might never iterate

https://github.com/rust-lang/rust/pull/100094

Detect type mismatch due to loop that might never iterate

> @lyming2007 that seems very close! I'll add comments in the PR. committed the changes as you suggested which is very helpful. Please check if I missed anything. @estebank

Detect type mismatch due to loop that might never iterate

@estebank thanks for the review and suggestions. Can you take a look at https://github.com/rust-lang/rust/pull/99064 by the way? It's been a while since I fixed it