Yonggang Luo

Results 204 comments of Yonggang Luo

may optimize by webasdembly

This is for mesa: https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16671

> Is this solving the same problem as #4178? Something alike, I quck look at #4178, I found it's `#include ` in `include/dxc/Support/WinAdapter.h` and that's will expose the whole `windows.h`...

even thout minValue maxValue are equal can resolve the issue, but a new problem arising, I won't the encoded SBE buffer are fixed size and are pre-know, by using group...

``` 0 1 0 1 2 ``` I suggest add Array Composite type

There is objection, https://www.bignerdranch.com/blog/default-exports-or-named-exports-why-not-both/ I am bitten by these things. maybe webpack better to provide a optionMap to config each node module are default export or named export.

> Using named exports would solve all problems. Convice me doesn't solve the problem, need convnce everyone and that's not possible.

> In this particular case technically these are named exports. There is no "primary" thing here and combining into single object does not solve any problem. If you will need...

Look at the dist file index.mjs, it's ends with default export, that's truely annoy. ``` const JSON5 = { parse, stringify, }; var lib = JSON5; export default lib; ```...

> If you want the common `modbus` part, there's `modbus-pdu` which this module uses. I wanna use stream.js only and provide own driver