L.Y

@jflo I added a unit test that already covers all the code of the BesuControllerBuilder.build() method. Could you check it and suggest more places that need modification?

First, I renamed the parameter names. Next, I added unit tests in BesuControllerBuilderTest. There are two new unit tests. The first one addresses the scenario where the node is started...

Additionally, this is the test coverage report, which shows that the coverage for the modified content is 100%: Pic 1: dditionally, this is the test coverage report, which shows that...

Just now, I rebased the code to the latest because this branch has conflicts that must be resolved in "besu/src/test/java/org/hyperledger/besu/controller/BesuControllerBuilderTest.java". And I dropped the unit test about BesuControllerBuilder because BesuControllerBuilderTest.java...

Due to the CI check failing, I rebased the branch code to the latest again, but did not change the source code, just rebased to the latest. Because I ran...

@macfarla Every time I update the code to the latest version, I need to restart the CI checks. Is this a normal process? Because this means that the entire repository...

> @lyfsn Great work on the PR, I have few questions if you don't mind : > > * Is there a way to reproduce the numbers on my side,...

> @lyfsn thanks for the troubleshooting data, awesome work. I was able to reproduce some of the number with this PR, for `--genesis-state-hash-cache-enabled=true && block number=0`, but then I did...

> are your genesis files public? I would like to test them on the refactor, if not I will try to generate one with random data I sent an email...

Hey, I tested the current code; here are some records: |Status|Time|Memory Allocated| |------|----|----------------| |first start (database empty)|14 mins|658 GB| |second start (database not empty)|30 s|2.25 GB| Before your refactor, the...