Alex McGrath

Results 20 comments of Alex McGrath

I think it should be possible, I didnt look into doing that yet though. It shouldn't be too hard, taglib can get the sample rate I think. I'm not sure...

Where is the best place to add tests for a new resources/their create/delete testing? Also I tried to be quite thorough with adding the resource in the right places as...

> I would like to test this, can I do it now? Or would you like to rebase and fix the failing tests (they are probably flaky ones) first? I'll...

> @lxea Sorry, I only got to this today It seems the conflicting file (`api/client/proto/authservice.pb.go`) is not allowing for a complete build Fixed, sorry about that

> LGTM > > Just one question, is this message expected? > > If we try to get the installer without anything created we get > > ```shell > root@marco:/workspace#...

> Verify trusted clusters scenario and make sure there are no caching related errors when an older cluster is connected to the cluster running version built off of this branch....

> Are the webassets changes intended to be included here? > reverted > Also for future consideration, it is helpful to your reviewers if you don't squash commits during the...

> @lxea - this PR is large and will require admin approval to merge. Consider breaking it up into a series smaller changes. I think this was before I changed...

> Is there any process that prevents multiple SSM calls to the same instance? I'm asking because I mentioned this earlier and something must have slipped my mind while reviewing...

> Uhmn, and if the script didn't start yet because SSM is slow or down? SSM is part of the automation section for AWS, right? If yes, as far as...