Will Manning comments

Results 19 comments of


                                            Will Manning

Forbid unwrap, require expect with explanation

❤️

Refactor Vortex compressor

relatedly #128

Run tests with MIRI for crates that don't use FFI

MIRI currently fails: ``` test array::varbinview::test::flatten_array ... error: Undefined Behavior: incorrect layout on deallocation: alloc2920226 has size 32 and alignment 8, but gave size 32 and alignment 1 --> /Users/will/.rustup/toolchains/nightly-aarch64-apple-darwin/lib/rustlib/src/rust/library/alloc/src/alloc.rs:119:14...

Encoding: FSST

see https://github.com/duckdb/duckdb/blob/cca8cfe0a4e7b55970b9d6e488189ea13af6e10b/src/common/fsst.cpp

Clean up alignment

Related to #7

DType enum is a bit too big

see #94

Encoding: ALPRD

see https://github.com/duckdb/duckdb/blob/cca8cfe0a4e7b55970b9d6e488189ea13af6e10b/src/include/duckdb/storage/compression/alprd/alprd_compress.hpp

Encoding: ALPRD

![Screenshot 2024-09-16 at 17 26 51](https://github.com/user-attachments/assets/2f790f96-23eb-41be-9a1b-ba93823b5b59) from the ALP paper^

chore(deps): update rust crate pyo3 to 0.22.0

this will unblock once we upgrade arrow-rs to the yet-unreleased 53.0.0 https://github.com/apache/arrow-rs/pull/6126/files#diff-f4a8850fc9135e5fc32c7c537d6a615478d4924f05151f466f5784f3aa8b8611R57

Add cardinality estimate stat

I think we want this instead of HLL++: https://www.cidrdb.org/cidr2019/papers/p23-freitag-cidr19.pdf