Liwei Ji
Liwei Ji
I confirm the this change make CarpetX compile on vista with nvc compilers
> @lwJi please click on "approve" if you are happy with the proposed change. I can't find a "approve" button on my side
1. This is only used for the purpose of higher order flux correction (for shock detection purposes). 2. There might be a cell centered version of Z4cow at some point.
It only used to detect shocks. It's an approximation to the cell center value of that cell and it's good enough for shock detection. `calc_copy` is only copy from GF3D2...
I don't understand. I need cell-centered derivative of a cell-centered grid function for shock detection purpose. The easiest way is to use finite difference. right?
It’s cell-average. But also an approximation of cell center value. Do you have a even easier way to construct derivative than finite difference
`Derivs` only provide finite difference
I think cell-centered grid is more fundamental at amrex level. However, the user can use it to represent cell-average (just as what we did with AsterX). This PR just provides...
If the user is using cell-centered grid as cell-average, and finite difference is not an approximation for the derivatives, they can just not call `Derivs` to get the derivatives.
When you say that CarpetX assume that `` is cell average, I believe you are talking about prolongation. But I believe we have prolongation operator which is not conserved also.