luzpaz
luzpaz
Probably the 1st option for consistency, right?
@chennes should we consider having a github action that scans new PRs for this pattern and suggests the indicated replacement ?
@Floriansimmer have you seen a GH action like that int he wild?
Actually, just doing a simple regex string `connect\(this,` search, I count give or take 4 dozen instances. There are also `disconnect(this` statements.
@donovaly maybe after toponaming? realthunder is experiencing a lot of annoying cosmetic changes as he works on merging toponaming, see his status update https://forum.freecadweb.org/viewtopic.php?p=611902#p611902
Looks like upstream merged the fix. It's should be in OCC 7.6.2 Testers needed
@wayofwood I've made a PR to your branch in https://github.com/wayofwood/FreeCAD/pull/1
@donovaly codespell ci is reporting typos of the full codebase (rather than just text of the PR changes) any idea why?
> Thanks - really appreciate your help. I am still trying to get my head around all the git workflow ... @wayofwood I totally get it. Keep practicing it make...
@realthunder could you take a look at this (in lieu of your work on #6506) CC @Roy-043 @0penBrain