luyuncheng
luyuncheng
i want to talk about the memory reduce scenarios. if we just write the vector into file like indexFlat format in java layer. and we do not transfer the memory...
> yes that is one possibility, but this assumes that while creating the index we are reading the file partially in efficient fashion because during index creation too, you need...
@navneet1v @jmazanec15 i resolved all review comments and all tests passed.
> AFAIK, the plugin's sub fetch phases will run after the OS core engine's sub fetch phases, which includes the `FetchSourcePhase` used for source filtering. Therefore, if I exclude a...
> The only exception for this is the InnerHit Fetchphase. The inner hit fetch phase is run at the end. Ref: https://github.com/opensearch-project/OpenSearch/blob/52b27f47bca5b3ab52cab237542f32c307d203b4/server/src/main/java/org/opensearch/search/fetch/FetchPhase.java#L104-L107 The order of these phases cannot be changed....
> > The order of these phases cannot be changed. > > @navneet1v Indeed, this is the key point that I want to emphasize, and it is precisely why I...
> @luyuncheng can we fix up the comments and so that we can merge this change? @navneet1v FIXED at https://github.com/opensearch-project/k-NN/pull/1571/commits/2a61fcda4ceef36829bbfa2a1748f2c5b6bbe7df
> @luyuncheng can you add details around what is Index RES and Query RES? @navneet1v Index Res: Build Graph Index takes a long time, i use a monitor to check...
@jmazanec15 > we decided to explicitly support algorithms. LGTM > So, I think before accepting a new algorithm, we need to come up with a process that we should go...
> do you have any feedback? Do you think there are any steps missing? @jmazanec15 I like the process steps. Nothing to add. Thanks for it !