luyuncheng

Results 48 comments of luyuncheng

> In terms of source storage, there is an issue over here: https://github.com/opensearch-project/OpenSearch/issues/6356 @jmazanec15 @navneet1v In #1571 I create a pr, which is WIP. and it shows how my idea...

@navneet1v Easy test: 1. create index with ``` {"mappings":{"_source": {"excludes": ["vector_field1"] }, "properties": {"vector_field1": {"type": "knn_vector", "dimension": 2 }, "vector_field2": {"type": "knn_vector", "dimension": 4 }, "number_field": {"type": "long"} } }...

> My question was how we are ensuring that KNNSubphase is not running during the search and running only during the re-indexing. @navneet1v gotcha, I will do the continues tests...

> My question was how we are ensuring that KNNSubphase is not running during the search and running only during the re-indexing. @navneet1v i tested search source and reindex scenarios...

> Why cant we have public BytesRef nextValue() throws IOException { return the whole string represetation of the current vector? @jmazanec15 as I see, we say `synthetic source` field is...

> Also there is something called as _recovery_source which is added as a fallback to support the re-indexing. @navneet1v I added [IT tests](https://github.com/opensearch-project/k-NN/pull/1571/commits/ba7de9db38d6919281d602a684cb4ca6befcd444) for the search, and reindex scenarios, I...

@navneet1v @jmazanec15 i rebased it from master. and would you pls review it? and i see @navneet1v have an issue: https://github.com/opensearch-project/OpenSearch/issues/13490, i am wondering this pr could be merged or...

@navneet1v @jmazanec15 At https://github.com/opensearch-project/k-NN/pull/1571/commits/469fbf3af3c2a7956537aa0b8760f70c3eb575e3 i added nested field process logic. and added tests for update, search, reindex, nested scenarios. > can we test update use case too. Ref: https://github.com/opensearch-project/k-NN/issues/1694 @navneet1v...

> The thing which I was really interested in testing was https://github.com/opensearch-project/k-NN/issues/2 and seems like it is not possible. @navneet1v i added tests at https://github.com/opensearch-project/k-NN/blob/256c32ae5679d8c52b8aab291f1b19e5a8570f3c/src/test/java/org/opensearch/knn/index/KNNSyntheticSourceIT.java#L368 2nd scenarios i think it...