John E. Vincent

Results 13 comments of John E. Vincent

:+1: @scottmuc As someone else pointed out, Vagrant is very explicit about this: https://github.com/mitchellh/vagrant/tree/master/keys

We could set the type from the shipper side but remember that all inputs in logstash require `type` anyway. Logstash SHOULD set that on input. If it's not, we've got...

I'll take a look at the atlassian fork. I just did a huge refactor of my rundeck library that unifies the code base to a single package oath and supports...

So I'd love it if @dillon-giacoppo and @jbrockopp would take a gander at these two things: https://github.com/lusis/go-rundeck/blob/master/README.md https://github.com/lusis/go-rundeck/tree/master/pkg/rundeck This is the path I was planning on going down with the...

@dillon-giacoppo the main reason for the layout is one of personal consistency. At work we follow roughly this: https://peter.bourgon.org/go-best-practices-2016/#repository-structure (I know helm follows a similar pattern: https://github.com/kubernetes/helm) As to the...

Just one more thing to add, I've found through taking the response/request break-out approach that I've been able to separate the API's construct of an object from the higher level...

@dillon-giacoppo @jbrockopp take a look at: https://github.com/lusis/go-artifactory/tree/single-dir Specifically: https://github.com/lusis/go-artifactory/blob/single-dir/pkg/artifactory/user.go compared with the original implementation. This will give you a feel for the direction I'm planning on going. Again, none of...

I just want to be clear that I'm still going to be creating tags or branches as checkpoints but the GOAL is that master degrades gracefully for users of older...

As for the details of the graceful degradation, I wrote a little bit about it here: https://github.com/lusis/pkg/blob/master/versioner/README.md