Ted Mielczarek

Results 181 comments of Ted Mielczarek

I wasn't involved in Breakpad from the *very* beginning, so I can't speak to the precise original motivation, but I know that the primary reason for translating native symbols to...

These are all things I'm very interested in! I'm very open to changes in the existing design of things in the minidump / breakpad-symbols crates. As I said, I wrote...

Touching base here again because one of my colleagues mentioned symbolic to me just now. A few of us at Mozilla are planning to start work on replacing our existing...

> @luser would you be interested in getting these changes upstream into `breakpad-symbols`? It definitely makes sense to centralize code at this point. Remaining action items would then be: My...

Question on the mechanics here: do you want to take the code you've written and put it in the `breakpad-symbols` crate in this repo, or would you prefer to just...

> I guess users would primarily want to override the symbol supplier, but not necessarily symbol file parsing etc I don't think we have enough knowledge of use cases to...

FYI, I have a WIP GDB remote protocol implementation in Rust here: https://github.com/luser/rust-gdb-remote-protocol/ It's mostly focused on implementing the server side of the protocol, but it might be an interesting...

Interestingly, Breakpad's Windows `dump_syms` implementation includes this same bug: https://chromium.googlesource.com/breakpad/breakpad/+/bd4a28c08b9d97bc4910f527f3c3ae232fdc5747/src/common/windows/pe_util.cc#232

FYI, I don't believe this is actually stored in PDB files anywhere? The Breakpad implementation reads it out of the PE headers. However, minidumps conveniently [include this information](https://docs.rs/minidump/latest/minidump/struct.MinidumpModule.html), so that...

> I don't know where this INFO line comes from, but it's in the sym files we've got on Mozilla Symbols Server. The `dump_syms` that creates those files gets it...