Ted Mielczarek

Results 181 comments of Ted Mielczarek

n.b. I went all-out on `disasm` and that Rust impl of `get-minidump-instructions`—not only can they automatically fetch the matching source files to provide source-interleaved assembly, but they will also syntax...

> One thing we could consider as a first step is to just expose that raw binary dump to the user in non-dump modes, and then they can disassemble it...

I suspect [WinDbg's `!handle` command](https://docs.microsoft.com/en-us/windows-hardware/drivers/debugger/-handle) is the gold standard for what you can get out of this data.

> How do people feel about switching to the `rangemap` crate (no dash between "range" and "map")? https://docs.rs/rangemap/ I think a suitable crate like this probably didn't exist when I...

Note that the current design tried to strike a balance between utility and privacy concerns: obviously the registers from the exception context are incredibly valuable for investigating crashes! Register contents...

[Having looked into this in the past in other contexts](https://bugzilla.mozilla.org/show_bug.cgi?id=575100#c6) (specifically: minidumps with some missing information, like modules without associated CV records, so missing debug IDs etc), my understanding is...

I've probably pointed you at this before, but there's some prior art in the [jit-crash-categorize](https://github.com/mozilla-services/minidump-stackwalk/blob/634f9624f5583521e79039e9d29b498f971a4fb4/minidump-stackwalk/jit-crash-categorize.cc) tool. dvander and I collaborated on it originally, and it looks like dmajor did some...

> Oh weird, why did no one complain that I didn't port this. Was it never turned on? I honestly can't remember if we had it wired up in prod?...

For some background on `jit-crash-categorize` see: - https://bugzilla.mozilla.org/show_bug.cgi?id=1124241 - https://bugzilla.mozilla.org/show_bug.cgi?id=1268029 - https://bugzilla.mozilla.org/show_bug.cgi?id=764223

Mozilla's Treeherder has an [intermittent failures dashboard](https://treeherder.mozilla.org/intermittent-failures/main?startday=2022-02-17&endday=2022-02-24&tree=trunk) that tracks flaky tests, [the display for a single issue](https://treeherder.mozilla.org/intermittent-failures/bugdetails?startday=2022-02-17&endday=2022-02-24&tree=trunk&bug=1692701) is a graph + table of failures.