Andrew Scheller

Results 2239 comments of Andrew Scheller

Sounds like a good idea, but I've not looked at the HSTX stuff myself, so pinging @Wren6991 and @kilograham for their thoughts.

Example is failing to build in CI: ``` /opt/actions-runner/_work/pico-examples/pico-examples/pico-examples/pio/rs422_tx/rs422_tx.pio:27.9-12: syntax error, unexpected next 27 | jmp next side 0b01 [3] | ^~~~ /opt/actions-runner/_work/pico-examples/pico-examples/pico-examples/pio/rs422_tx/rs422_tx.pio:30.1-4: syntax error, unexpected next 30 | next:...

> I changed the label. Thank you. Thanks @yoneken , CI is building cleanly now :slightly_smiling_face:

Hmmm, maybe there ought to be a `gpio_init_mask64` function, similar to the various other `*_masked64` functions in that file? (Also, perhaps it makes sense to change `void gpio_init_mask(uint gpio_mask)` to...

Feel free to defer this to a later milestone, if you think that'd be appropriate :slightly_smiling_face:

> Yes, looks like some bitrot. Try adding the following... > > ``` > #define xstr(s) str(s) > #define str(s) #s > ``` Hmmm, I wonder why this wasn't failing...

Rather than adding a new `colored_status_led_change_color` function, does the original code work as expected if you change https://github.com/raspberrypi/pico-sdk/blob/develop/src/rp2_common/pico_status_led/status_led.c#L83 from ```c if (led_on && !colored_status_led_on) { ``` to ```c if (led_on)...

Sounds similar to #3138 ?

Huh, I assume you're talking about https://github.com/raspberrypi/rpi-eeprom/commit/7f66ffe483698e788858fe51000217849fa6331f ? It sounds like that's specific to CM5 only? > so this should no longer be necessary on whatever the next eeprom revision...

Could you provide more details about which exact Flash chips you're using, and which RP2350 board you're using? Also, if you're able to provide a more complete code-example, that might...