Luo Xiu

Results 9 comments of Luo Xiu

Hi @kidsid-Ixigo , thank you for your report. I can't reproduce this with the code above, can you give me a demo if you don't mind? By the way, you...

🤔 https://github.com/cx-org/CombineX/runs/2723742441?check_suite_focus=true#step:3:396

> Still here? Better use relative path or ignore it. Will add this to gitignore, 🤦🏻‍♀️, carthage doesn't support relative path as far as I know.

> What is the purpose of > the extra folder `package-manager` in `IntegrationTests/`? I prefer a flatter structure. Probably `IntegrationTests/[SwiftPackage|Carthage|CocoaPods]/`? Will add more integration tests in the future, for example,...

Actually, it allows: ```swift let n: Int? = nil let x: Any = n as Any ``` > > > Swift 5.7 does allow `Any` value to store a wildcard...

Changing `case nil:` to ` case Optional.none:` will fix this issue, already raised a pr here: https://github.com/SwiftyJSON/SwiftyJSON/pull/1124.

> @luoxiu 🤔 Is it really possible to get into the branch of `Optional.none`? I still feel that `case nil` should be removed directly. Yes, take a look at the...

Should be closed since `no_magic_numbers` is already implemented in #4265 ~

```swift let string = """ { "foo": null } """ let json = JSON(parseJSON: string) // check if the key exists json["foo"].exists() // true // check if the key is...