Results 461 comments of Lunny Xiao

The compress maybe as an interface so that external could implement themselves.

We need a more abstract layer to read secrets from ini file, envs, docker secrets, k8s secrets.

> > We need a more abstract layer to read secrets from ini file, envs, docker secrets, k8s secrets. > > This would allow that in the future, as we...

> There is a small bug in #20571 whereby `$a a$b b$` will not be correctly detected as a math inline block of `a a$b b`. This PR fixes this....

Good job. But a tree view is better.

I have tested it and I think it's mature enough as the first step. But find out that performance is a problem when there are over one hundred of files...

Please resolve the conflict

> Just two small questions: > > 1. I'd made the requested changes. Should I request a re-review, or is it enough that they are in the "resolved" state? >...

Please resolve the conflicts.

> @lunny, I find you comment very dry. I have been working on this PR for 3 months, I tried to quickly address all comments of the 5 reviewers, (I...