gitea icon indicating copy to clipboard operation
gitea copied to clipboard

Published 20 hours ago • verified publisher icon go-gitea

Fix slight bug in katex

Open zeripath opened this issue 2 years ago • 1 comments

There is a small bug in #20571 whereby $a a$b b$ will not be correctly detected as a math inline block of a a$b b. This PR fixes this.

Signed-off-by: Andrew Thornton [email protected]

zeripath avatar Sep 14 '22 16:09 zeripath

There is a small bug in #20571 whereby $a a$b b$ will not be correctly detected as a math inline block of a a$b b. This PR fixes this.

Signed-off-by: Andrew Thornton [email protected]

Maybe a new test is better.

lunny avatar Sep 15 '22 12:09 lunny

OK tests added.

zeripath avatar Oct 04 '22 22:10 zeripath

I closed #21340, could the fixes be taken in this one?

  • https://github.com/zeripath/gitea/pull/14
  • Add missing os.Exit(m.Run()) to markup/html_test.go and fix the test in TestRender_emoji
  • Fix a overflow bug in markup/markdown/meta.go
  • Fix the string vs bytes comparison in markup/markdown/meta_test.go
  • Remove unnecessary util.Dedent, YAML can accept global indention.
  • The comment Trigger returns nil is not touched, not sure what should be written there.

wxiaoguang avatar Oct 05 '22 02:10 wxiaoguang

make lgtm work

zeripath avatar Oct 05 '22 18:10 zeripath