Morten Brekkevold

Results 288 comments of Morten Brekkevold

So, I've implemented the remaining features from the checklist, and done some preliminary testing. This might do well with added test coverage, but I'll submit it as is for review...

Also, I'd like to look at SonarQube settings, if at all possible. It complains about missing docstrings for several functions, our old policy when using PyLint was that only *public*...

> > Also, I'd like to look at SonarQube settings, if at all possible. It complains about missing docstrings for several functions, our old policy when using PyLint was that...

**Clarification:** Adding multiple sources in the "source" filter is actually an OR combination. Nothing else would make sense. However, tag filters are ANDed together, and the set of sources and...

> Yes, this was added in #3157, were it was mentioned that "there is no (reliable) way to check whether a Django form is a POST form thats why this...

At this point, I've identified and created issues for CSRF problems in at least 4 tools. These have all been linked to this PR. I suspect there may also be...

> @lunkwill42 Should we resolve this bug #3472 before merging this PR? Should be fairly simple by only rendering the `{% csrf_token %}` if the current method is _not_ `get`...

> > The patch looks absolutely fine, but I don't seem to be able to reproduce the mentioned bug, and there's no mention of how to do it... > >...

> This only applies to boolean sensors, for all others it works as expected Indeed, I suspected this in the end. I'll try to make a mental note of amending...

It is notoriously difficult for end users to discern whether a bug is a "back-end" or "front-end" issue anyway, so I think we need a single bug template that encompasses...