Łukasz Kosmaty

Results 32 issues of Łukasz Kosmaty

# Why I forgot to throw exceptions in two corner cases: - when js type is not convertible to a Kotlin object - like Symbol - when the js value...

bot: suggestions

# Why # How # Test Plan # Checklist - [ ] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [ ] Conforms with...

bot: suggestions

# Why Closes ENG-5152. A follow-up to the https://github.com/expo/expo/pull/18438. # How Added callMethod to the new native modules proxy so we can call native methods of legacy modules through the...

bot: suggestions

# Why Fixes instrumented tests can't be run from the `bare-expo` project. # How While dealing with another issue, I came across a problem - I couldn't run instrumented tests...

bot: suggestions

# Why Closes https://github.com/expo/expo/issues/23189. # How # Test Plan # Checklist - [ ] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [ ]...

bot: suggestions

# Why Removes unused `SVG` workaround for older Android devices. # How For some Android devices, we had to change the `LayerType` to software. This workaround wasn't working, because we...

# Why Fixes https://github.com/expo/expo/issues/23457. # How During the Gradle test, a dependency between two tasks was discovered: `expo-constants:packageDebugAssets` and `expo-constants:copyReleaseExpoConfig`. This occurred because both the `Release` and `Debug` variants utilize...

bot: suggestions

# Why Closes https://github.com/expo/expo/issues/21937. # How When `migrateAlbumIfNeededAsync` was invoked on an empty album, the `the bind value at index 1 is null` was thrown. Ensures that the album has...

bot: suggestions

# Why Fixes `albumNeedsMigrationAsync` crashing if called with an invalid `albumId` on Android. # How Add missing try-catch block. # Test Plan - bare-expo ✅

bot: suggestions

# Why I noticed code redundancy while trying to add more test cases. Extracting patterns made our test code cleaner. Now, it's easier to add more tests. # Test Plan...

bot: suggestions
bot: fingerprint changed