Luke Sandberg

Results 9 comments of Luke Sandberg

deleting this condition https://github.com/bazelbuild/buildtools/blob/master/edit/buildozer.go#L310 fixes this issue, @laurentlb thought this might break users.

i think it would be reasonable to start releasing the well known types in strict mode to npm, a la https://github.com/protocolbuffers/protobuf/pull/8955

The problem is utf8 encoding as dibenede said. When you change your type to string that will get utf8 encoded when you call serializeBinary(), so when you wrap it in...

Java Lite protos similarly don't provide registries to support any The goal in both cases is the same, don't leak type names by default. As such it does shift a...

This is _intentionally_ unimplemented. You are correct that we could modify our generated code so that every message would know its own name and thus simply the `pack` API and...

querying for `globalThis` first is probably reasonable `typeof window != "undefined" && window` would also work i suppose

Interesting, looks like a simple issue to address in our code generator. maybe just remove the `./`? We do not actually test with the `buf` toolchain so i am not...

i think this is a case where we would need a new API it would be reasonable to expect some customers to want to run with asserts and debug code...

this will require modifying to code generator to allow for either format on the wire and our BinaryReader to add helpers for 'packable' fields